Re: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set but not used

[Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>]

On 3/26/2024 11:19 AM, Dmitry Baryshkov wrote:
> On Tue, 26 Mar 2024 at 20:05, Miguel Ojeda
> <miguel.ojeda.sandonis@xxxxxxxxx> wrote:
> > Hi,
> >
> > In today's next, I got:
> >
> >      drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable
> > 'out' set but not used [-Werror,-Wunused-but-set-variable]
> >
> > `out` seems to be there since commit 64d6255650d4 ("drm/msm: More
> > fully implement devcoredump for a7xx").
> >
> > Untested diff below assuming `dumper->iova` is constant -- if you want
> > a formal patch, please let me know.
>
> Please send a proper patch that we can pick up.

This should be fixed with https://patchwork.freedesktop.org/patch/581853/.

We can pickup that one with a Fixes tag applied.

> > Cheers,
> > Miguel
> >
> > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
> > b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
> > index 1f5245fc2cdc..a847a0f7a73c 100644
> > --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
> > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
> > @@ -852,7 +852,7 @@ static void a6xx_get_shader_block(struct msm_gpu *gpu,
> >               (block->type << 8) | i);
> >
> >           in += CRASHDUMP_READ(in, REG_A6XX_HLSQ_DBG_AHB_READ_APERTURE,
> > -            block->size, dumper->iova + A6XX_CD_DATA_OFFSET);
> > +            block->size, out);
> >
> >           out += block->size * sizeof(u32);
> >       }