On Sun, Mar 24, 2024 at 12:57:43PM +0200, Dmitry Baryshkov wrote: > On Sun, 24 Mar 2024 at 12:30, Akhil P Oommen <quic_akhilpo@xxxxxxxxxxx> wrote: > > > > On Sat, Mar 23, 2024 at 12:57:02AM +0200, Dmitry Baryshkov wrote: > > > Generate DRM/MSM headers on the fly during kernel build. This removes a > > > need to push register changes to Mesa with the following manual > > > synchronization step. Existing headers will be removed in the following > > > commits (split away to ease reviews). > > > > Is this approach common in upstream kernel? Isn't it a bit awkward from > > legal perspective to rely on a source file outside of kernel during > > compilation? > > As long as the source file for that file is available. For examples of > non-trivial generated files see > arch/arm64/include/generated/sysreg-defs.h and > arch/arm64/include/generated/cpucap-defs.h I see that the xml files import a GPL compatible license, so I guess those are fine. The gen_header.py script doesn't include any license. Shouldn't it have one? -Akhil. > > -- > With best wishes > Dmitry
