Since this new platform supports both DP and eDP, it's the perfect time to drop the dual compatible (eDP and DP) and figure out a different way to specify the mode. After some off-list discussion, one suggested way was to add a 'is-edp' property to the controller node, but that approach has been dropped due to bindings concerns. So now we lookup the panel node in DT and based on it's presence we can safely say if it is eDP or not. The PHY counterpart patchset is here: https://lore.kernel.org/all/20240324-x1e80100-phy-edp-compatible-refactor-v5-0-a0db5f3150bc@xxxxxxxxxx This patchset cannot be applied without the one mentioned above because it relies on PHY_SUBMODE_EDP and PHY_SUBMODE_DP. Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx> --- Changes in v4: - Reworked the dp_display_get_connector_type to be more readable, like Bjorn suggested. - Dropped the unrelated change w.r.t. dp_aux_get call, reported by Dmitry. - Re-worded the commit message for the first patch, to align with Dmitry's suggestion. - Added Dmitry's R-b tag to the X1E80100 specific patch - Link to v3: https://lore.kernel.org/r/20240322-x1e80100-display-refactor-connector-v3-0-af14c29af665@xxxxxxxxxx Changes in v3: - Dropped the bindings patch as this new solution doesn't involve bindings update. - Dropped R-b tags as this has been entirely reworked - Reworked to lookup the panel node in DT and set the is_edp and connector type based on panel node presence - Link to v2: https://lore.kernel.org/r/20240222-x1e80100-display-refactor-connector-v2-0-bd4197dfceab@xxxxxxxxxx Changes in v2: - Added Dmitry's R-b tag to both driver patches - Dropped the if statement around assigning the is_edp in dp_display_probe, and fixed said assignment by using the connector type from match data instead. - Moved the qcom,x1e80100-dp compatible where it belongs - Re-worded the bindings commit message to follow Bjorn's suggestion - Dropped the RFC tag as the approach doesn't seem to be questioned anymore - Link to v1: https://lore.kernel.org/r/20240221-x1e80100-display-refactor-connector-v1-0-86c0e1ebd5ec@xxxxxxxxxx --- Abel Vesa (2): drm/msm/dp: Add support for determining the eDP/DP mode from DT drm/msm/dp: Add support for the X1E80100 drivers/gpu/drm/msm/dp/dp_display.c | 38 ++++++++++++++++++++++++++++++++++++- 1 file changed, 37 insertions(+), 1 deletion(-) --- base-commit: 13ee4a7161b6fd938aef6688ff43b163f6d83e37 change-id: 20231219-x1e80100-display-refactor-connector-e1c66548cae3 Best regards, -- Abel Vesa <abel.vesa@xxxxxxxxxx>
