Acked-by: Alex Deucher <alexander.deucher@xxxxxxx> On Thu, Mar 21, 2024 at 2:14 PM Sunil Khatri <sunil.khatri@xxxxxxx> wrote: > > when CONFIG_DEV_COREDUMP is not defined in that case > when amdgpu_coredump() is called it does not find it's > definition and the build fails. > > This happens as the header is defined without the > CONFIG_DEV_COREDUMP ifdef and due to which header isn't > enabled. > > Pulling the header out of such ifdef so in both the > cases the build does not fail. > > Signed-off-by: Sunil Khatri <sunil.khatri@xxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index 95028f57cb56..f771b2042a43 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -74,10 +74,7 @@ > #include "amdgpu_fru_eeprom.h" > #include "amdgpu_reset.h" > #include "amdgpu_virt.h" > - > -#ifdef CONFIG_DEV_COREDUMP > #include "amdgpu_dev_coredump.h" > -#endif > > #include <linux/suspend.h> > #include <drm/task_barrier.h> > -- > 2.34.1 >