On Tue, Jan 23, 2024 at 12:32:17AM +0800, Sui Jingfeng wrote: > Which is intended to be used on non-DT environment, where the simple-bridge > platform device is created by either the display controller driver side or > platform firmware subsystem. To avoid duplication and to keep consistent, > we choose to reuse the OF match tables. Because the potentional user may > not has a of_node attached, nor a ACPI match id. If this is the case, > a software node string property can be provide to fill the niche. ... > - sbridge->info = of_device_get_match_data(&pdev->dev); > + if (pdev->dev.of_node) > + sbridge->info = of_device_get_match_data(&pdev->dev); > + else > + sbridge->info = simple_bridge_get_match_data(&pdev->dev); This is wrong. Just use device_get_match_data() instead of of_ counter part. The rest, if required, has to be addressed elsewhere. So, formal NAK for the changes like above. -- With Best Regards, Andy Shevchenko
