Re: [PATCH v2 6/6] backlight: Remove fb_blank from struct backlight_properties

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

Am 20.03.24 um 09:46 schrieb FLAVIO SULIGOI:
Hi Thomas,

...
Remove the field fb_blank from struct backlight_properties and remove all
code that still sets or reads it. Backlight blank status is now tracked exclusively
in struct backlight_properties.state.

The core backlight code keeps the fb_blank and state fields in sync, but doesn't
do anything else with fb_blank. Several drivers initialize fb_blank to
FB_BLANK_UNBLANK to enable the backlight. This is already the default for
the state field. So we can delete the fb_blank code from core and drivers and
rely on the state field.

Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
Cc: Flavio Suligoi <f.suligoi@xxxxxxx>
Cc: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>
Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
Cc: Claudiu Beznea <claudiu.beznea@xxxxxxxxx>
Tested-by: Flavio Suligoi <f.suligoi@xxxxxxx>
Reviewed-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
...

Can you explain what are the differences between the version 1 and version 2 of the patch?

There are none. It's simply labeled v2 because it is part of the version 2 of this series.

Best regards
Thomas

Thanks,
Flavio

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux