Hi,
On Tue, Mar 19, 2024 at 09:00:32AM +0100, Thomas Zimmermann wrote:
> Implement polling for VGA and SIL164 connectors. Set the flag
> DRM_CONNECTOR_POLL_DISCONNECT for each to detect the removal of the
> monitor cable. Implement struct drm_connector_helper_funcs.detect_ctx
> for each type of connector by testing for EDID data. The code for
> both types of connectors is identical for now. Maybe this can later
> become a common helper function for various drivers.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> ---
> drivers/gpu/drm/ast/ast_mode.c | 36 ++++++++++++++++++++++++++++++++--
> 1 file changed, 34 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
> index 71cc681d6188f..f740b8706a38b 100644
> --- a/drivers/gpu/drm/ast/ast_mode.c
> +++ b/drivers/gpu/drm/ast/ast_mode.c
> @@ -1344,8 +1344,24 @@ static int ast_crtc_init(struct drm_device *dev)
> * VGA Connector
> */
>
> +static int ast_vga_connector_helper_detect_ctx(struct drm_connector *connector,
> + struct drm_modeset_acquire_ctx *ctx,
> + bool force)
> +{
> + enum drm_connector_status status = connector_status_disconnected;
> + const struct drm_edid *edid;
> +
> + edid = drm_edid_read(connector);
> + if (edid)
> + status = connector_status_connected;
> + drm_edid_free(edid);
> +
> + return status;
> +}
> +
Yeah, I think it would be worth turning it into a helper. We have a
number of drivers using some variation of that already
(display-connector, loongson).
It's probably better to use drm_probe_ddc here too instead of parsing
and updating the EDID property each time we call detect.
Maxime
Attachment:
signature.asc
Description: PGP signature
