On Mon, 18 Mar 2024, Neil Armstrong <neil.armstrong@xxxxxxxxxx> wrote: > This reverts commit e3f18b0dd1db242791afbc3bd173026163ce0ccc. > > Selecting DRM_KMS_HELPER for DRM_PANEL_BRIDGE leads to: > WARNING: unmet direct dependencies detected for DRM_KMS_HELPER > Depends on [m]: HAS_IOMEM [=y] && DRM [=m] > ... > > and builds with CONFIG_DRM=m will fail with the above kconfig > warns and then multiple linker error. > > Reported-by: Imre Deak <imre.deak@xxxxxxxxx> > Reported-by: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> > Reported-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > Fixes: e3f18b0dd1db ("drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE") > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> Acked-by: Jani Nikula <jani.nikula@xxxxxxxxx> Tested-by: Jani Nikula <jani.nikula@xxxxxxxxx> > --- > drivers/gpu/drm/bridge/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig > index 1d4f010af97b..efd996f6c138 100644 > --- a/drivers/gpu/drm/bridge/Kconfig > +++ b/drivers/gpu/drm/bridge/Kconfig > @@ -8,7 +8,6 @@ config DRM_BRIDGE > config DRM_PANEL_BRIDGE > def_bool y > depends on DRM_BRIDGE > - select DRM_KMS_HELPER > select DRM_PANEL > help > DRM bridge wrapper of DRM panels > > --- > base-commit: e3f18b0dd1db242791afbc3bd173026163ce0ccc > change-id: 20240318-revert-select-drm_kms_helper-for-drm_panel_bridge-0e4ad7c73496 > > Best regards, -- Jani Nikula, Intel