On 18/03/2024 14:41, Ville Syrjälä wrote:
On Mon, Mar 18, 2024 at 12:52:10PM +0200, Jani Nikula wrote:
On Mon, 18 Mar 2024, Neil Armstrong <neil.armstrong@xxxxxxxxxx> wrote:
Hi,
On Thu, 11 Jan 2024 13:38:04 +0100, Luca Weiss wrote:
Since the kconfig symbol of DRM_PANEL_BRIDGE is only adding
bridge/panel.o to drm_kms_helper object, we need to select
DRM_KMS_HELPER to make sure the file is actually getting built.
Otherwise with certain defconfigs e.g. devm_drm_of_get_bridge will not
be properly available:
[...]
Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-fixes)
[1/1] drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/e3f18b0dd1db242791afbc3bd173026163ce0ccc
With my kernel config, e3f18b0dd1db ("drm/bridge: Select DRM_KMS_HELPER
for DRM_PANEL_BRIDGE") leads to:
WARNING: unmet direct dependencies detected for DRM_KMS_HELPER
Depends on [m]: HAS_IOMEM [=y] && DRM [=m]
...
All the defconfigs in drm-rerere also seem to fail here.
Neil, are you using some weird .config, or did you not actually
build test this before pushing?
It definitely built fine, but my config test is not extensive and went through it,
I'll send a revert patch ASAP.
Neil
PS. the drm-rerere defconfigs seem pretty outdated (eg. missing
tons of panel drivers). Would be good if someone could update
those to provide better coverage
