Based on work at https://lore.kernel.org/dri-devel/20230118032413.6496-1-jiasheng@xxxxxxxxxxx/ The API in the origional work seemed to have two issues: 1. The output parameter was not correctly defined 2. The allocating functions did not return the allocated object like the other drmm functions I tweaked the implementation to address both of these. >From what I can tell, the i915 change no longer applies to the code base, likely due to refactoring from merging xe. I dropped it. Jeffrey Hugo (1): accel/qaic: Use drmm_alloc_workqueue() Jiasheng Jiang (1): drm: Add DRM-managed alloc_workqueue() and alloc_ordered_workqueue() drivers/accel/qaic/qaic_drv.c | 30 ++----------- drivers/gpu/drm/drm_managed.c | 82 +++++++++++++++++++++++++++++++++++ include/drm/drm_managed.h | 8 ++++ 3 files changed, 94 insertions(+), 26 deletions(-) -- 2.34.1