On Mon, Aug 19, 2013 at 09:23:17AM +1000, Dave Airlie wrote: > On Thu, Aug 15, 2013 at 5:43 AM, Sebastian Hesselbarth > <sebastian.hesselbarth@xxxxxxxxx> wrote: > > From: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx> > > > > This patch adds tda998x specific parameters to allow it to be configured > > for different boards using it. Also, this implements rudimentary audio > > support for S/PDIF attached controllers. > > > > Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx> > > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx> > > Tested-by: Darren Etheridge <detheridge@xxxxxx> > > --- > > I've merged the series, Thanks. > this one generates a warning though: > CC [M] drivers/gpu/drm/i2c/tda998x_drv.o > /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/i2c/tda998x_drv.c: > In function ‘tda998x_encoder_mode_set’: > /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/i2c/tda998x_drv.c:637:11: > warning: ‘clksel_fs’ may be used uninitialized in this function > [-Wmaybe-uninitialized] > /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/i2c/tda998x_drv.c:573:30: > note: ‘clksel_fs’ was declared here > /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/i2c/tda998x_drv.c:637:11: > warning: ‘clksel_aip’ may be used uninitialized in this function > [-Wmaybe-uninitialized] > /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/i2c/tda998x_drv.c:573:18: > note: ‘clksel_aip’ was declared here > > It doesn't seem like a real problem, since the function is unlikely to > be called any way to make that case happen. Ok, I'll squash those warnings by a slight rearrangement of the code. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel