On Fri, Aug 16, 2013 at 02:23:35AM +0200, Patrik Jakobsson wrote: > On Sun, Aug 11, 2013 at 12:00 PM, Daniel Vetter <daniel@xxxxxxxx> wrote: > > On Sat, Aug 10, 2013 at 10:12 PM, Patrik Jakobsson > > <patrik.r.jakobsson@xxxxxxxxx> wrote: > > If you take this opportunity to share a bit of code between gma500 and > > i915 (the sdvo #defines header and maybe the sdvo i2c read/write and > > cmd helpers) I'd be interested in such a patch. We probably need an > > struct intel_sdvo_chip to abstract away a few things. > > -Daniel > > I'll take a look at it. Does i915 also have GMBUS and GPIOs spread out > on different > devices like the minnow? GPIOs seem to be accessed through LPC. Hm, we always have the intel gmbus controller, but at different offsets. In any case the abstraction provided by i2c_adapter should be more than enough I hope. In drm/i915 we always use the bit-banging i2c encoder, but such quirks are all handled within the i2c_adapter we pass to the low-level sdvo i/o functions. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
