On Sat, Aug 10, 2013 at 11:19 AM, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: > On Sat, Aug 10, 2013 at 10:55:08AM +0200, Daniel Vetter wrote: >> On Sat, Aug 10, 2013 at 9:06 AM, Guillaume Clement <gclement@xxxxxxxxxx> wrote: >> > Some Poulsbo cards seem to incorrectly report SDVO_CMD_STATUS_TARGET_NOT_SPECIFIED instead of SDVO_CMD_STATUS_PENDING, which causes the display to be turned off. >> > >> > Signed-off-by: Guillaume Clement <gclement@xxxxxxxxxx> >> >> >> Can you please submit the exact same change for drm/i915/intel_sdvoc.c >> too? The sdvo encoders can be the same ones for psb and i915 so having >> the same code would be great. Separate patch for drm/i915 ofc. > > Are you absolutely sure that is a hardware error and not a software SDVO > protocol goof? TARGET_NOT_SPECIFIED seems pretty specific. No idea, but since the code still retries a limited amount and then still fails I can imagine that a few sdvo encoders just have a hard time waking up and responding with something useful. In all cases we log the actual return value and everything interesting. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
