Hi kernel test robot et al. On Sun, Mar 10, 2024 at 06:37:53PM +0800, kernel test robot wrote: > Hi Sam, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on 84b76d05828a1909e20d0f66553b876b801f98c8] > > url: https://github.com/intel-lab-lkp/linux/commits/Sam-Ravnborg-via-B4-Relay/sparc32-Update-defconfig-to-LEON-SMP/20240310-021717 > base: 84b76d05828a1909e20d0f66553b876b801f98c8 > patch link: https://lore.kernel.org/r/20240309-sunset-v2-14-f09912574d2c%40ravnborg.org > patch subject: [PATCH v2 14/28] sparc32: Drop unused mmu models > config: sparc-randconfig-r113-20240310 (https://download.01.org/0day-ci/archive/20240310/202403101854.Z94SAU13-lkp@xxxxxxxxx/config) > compiler: sparc-linux-gcc (GCC) 13.2.0 > reproduce: (https://download.01.org/0day-ci/archive/20240310/202403101854.Z94SAU13-lkp@xxxxxxxxx/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > | Closes: https://lore.kernel.org/oe-kbuild-all/202403101854.Z94SAU13-lkp@xxxxxxxxx/ > > sparse warnings: (new ones prefixed by >>) > >> arch/sparc/mm/srmmu.c:49:5: sparse: sparse: symbol 'vac_line_size' was not declared. Should it be static? > > vim +/vac_line_size +49 arch/sparc/mm/srmmu.c > > accf032cfa582e Sam Ravnborg 2012-05-19 46 > ^1da177e4c3f41 Linus Torvalds 2005-04-16 47 int vac_cache_size; > 9d262d95114cf2 Guenter Roeck 2017-04-01 48 EXPORT_SYMBOL(vac_cache_size); > ^1da177e4c3f41 Linus Torvalds 2005-04-16 @49 int vac_line_size; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 50 vac_line_size is no longer used and can be deleted. vac_cache_size is never written to and can be deleted too. vac_cache_size is used in shmparam_32.h like this: #define SHMLBA (vac_cache_size ? vac_cache_size : PAGE_SIZE) The same file has: #define __ARCH_FORCE_SHMLBA 1 If I understand it right then when SHMLBA equals PAGE_SIZE then there is no need to define __ARCH_FORCE_SHMLBA and sparc32 can use the asm-generic variant of shmparam.h I will do this change in v3. Sam
