Hi, On Tue, Feb 27, 2024 at 3:26 PM Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> wrote: > > On Wed, 28 Feb 2024 at 00:19, Douglas Anderson <dianders@xxxxxxxxxxxx> wrote: > > > > Even though the UDL driver converts to RGB565 internally (see > > pixel32_to_be16() in udl_transfer.c), it advertises XRGB8888 for > > compatibility. Let's add ARGB8888 to that list. > > > > This makes UDL devices work on ChromeOS again after commit > > c91acda3a380 ("drm/gem: Check for valid formats"). Prior to that > > commit things were "working" because we'd silently treat the ARGB8888 > > that ChromeOS wanted as XRGB8888. > > > > Fixes: c91acda3a380 ("drm/gem: Check for valid formats") > > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > > --- > > > > drivers/gpu/drm/udl/udl_modeset.c | 1 + > > 1 file changed, 1 insertion(+) > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> It's been ~a week, the fix is trivial, and according to MAINTAINERS this driver goes through drm-misc. ...so I've applied this with Dmitry's tag (thanks!) to drm-misc-fixes. 95bf25bb9ed5 drm/udl: Add ARGB8888 as a format -Doug