On Tue, 05 Mar 2024, Thomas Zimmermann <tzimmermann@xxxxxxx> wrote: > Fix builds with CONFIG_PMAC_BACKLIGHT=y. The include statement for the > backlight header has recently been removed from <linux/fb.h>. Add it to > via-pmu-backlight.c to get the necessary symbols. > > Reported-by: Naresh Kamboju <naresh.kamboju@xxxxxxxxxx> > Closes: https://lore.kernel.org/dri-devel/CA+G9fYsAk5TbqqxFC2W4oHLGA0CbTHMxbeq8QayFXTU75YiueA@xxxxxxxxxxxxxx/ > Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx> > Fixes: 11b4eedfc87d ("fbdev: Do not include <linux/backlight.h> in header") > Cc: Thomas Zimmermann <tzimmermann@xxxxxxx> > Cc: Jani Nikula <jani.nikula@xxxxxxxxx> > Cc: Helge Deller <deller@xxxxxx> > Cc: linux-fbdev@xxxxxxxxxxxxxxx > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx> > --- > drivers/macintosh/via-pmu-backlight.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/macintosh/via-pmu-backlight.c b/drivers/macintosh/via-pmu-backlight.c > index c2d87e7fa85be..89450645c2305 100644 > --- a/drivers/macintosh/via-pmu-backlight.c > +++ b/drivers/macintosh/via-pmu-backlight.c > @@ -10,6 +10,7 @@ > > #include <asm/ptrace.h> > #include <linux/adb.h> > +#include <linux/backlight.h> > #include <linux/pmu.h> > #include <asm/backlight.h> -- Jani Nikula, Intel