On 04/03/2024 21:41, Caleb Connolly wrote: > > > On 09/02/2024 00:16, Richard Acayan wrote: >> The S6E3FA7 display controller is enabled in every Pixel 3a (non-XL) >> variant. Add the driver for it, generated by >> linux-mdss-dsi-panel-driver-generator. >> >> There are other panels connected to the same S6E3FA7 display controller, >> such as the AMS604NL01 panel, which are incompatible with this driver. >> Name the device tree compatible after the panel model according to >> iFixit. >> >> Link: https://github.com/msm8916-mainline/linux-mdss-dsi-panel-driver-generator >> Link: https://android.googlesource.com/kernel/msm/+/7fda1cd7b64710dafac5f34899611c6d35eb4cd2/arch/arm64/boot/dts/google/dsi-panel-s6e3fa7-1080p-cmd.dtsi >> Link: https://github.com/msm8953-mainline/linux/blob/v6.6.12-r0/drivers/gpu/drm/panel/panel-samsung-s6e3fa7.c >> Link: https://www.ifixit.com/Guide/Image/meta/muyjtLQTHu6MDkhK >> Signed-off-by: Richard Acayan <mailingradian@xxxxxxxxx> >> --- >> drivers/gpu/drm/panel/Kconfig | 9 + >> drivers/gpu/drm/panel/Makefile | 1 + >> drivers/gpu/drm/panel/panel-samsung-s6e3fa7.c | 285 ++++++++++++++++++ >> 3 files changed, 295 insertions(+) >> create mode 100644 drivers/gpu/drm/panel/panel-samsung-s6e3fa7.c >> > >> diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e3fa7.c b/drivers/gpu/drm/panel/panel-samsung-s6e3fa7.c >> new file mode 100644 >> index 000000000000..10bc8fb5f1f9 >> --- /dev/null >> +++ b/drivers/gpu/drm/panel/panel-samsung-s6e3fa7.c >> @@ -0,0 +1,285 @@ > > [snip] >> + >> +static int s6e3fa7_panel_probe(struct mipi_dsi_device *dsi) >> +{ >> + struct device *dev = &dsi->dev; >> + struct s6e3fa7_panel *ctx; >> + int ret; >> + >> + ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL); >> + if (!ctx) >> + return -ENOMEM; >> + >> + ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH); >> + if (IS_ERR(ctx->reset_gpio)) >> + return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio), >> + "Failed to get reset-gpios\n"); >> + >> + ctx->dsi = dsi; >> + mipi_dsi_set_drvdata(dsi, ctx); >> + >> + dsi->lanes = 4; >> + dsi->format = MIPI_DSI_FMT_RGB888; >> + dsi->mode_flags = MIPI_DSI_MODE_VIDEO_BURST | > This flag is only used for video mode panels, you can drop it. Nevermind, I should really check the dates before hitting reply :/ > > With that, > > Reviewed-by: Caleb Connolly <caleb.connolly@xxxxxxxxxx> >> + MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM; >> + >> + drm_panel_init(&ctx->panel, dev, &s6e3fa7_panel_funcs, >> + DRM_MODE_CONNECTOR_DSI); >> + ctx->panel.prepare_prev_first = true; >> + >> + ctx->panel.backlight = s6e3fa7_panel_create_backlight(dsi); >> + if (IS_ERR(ctx->panel.backlight)) >> + return dev_err_probe(dev, PTR_ERR(ctx->panel.backlight), >> + "Failed to create backlight\n"); >> + >> + drm_panel_add(&ctx->panel); >> + >> + ret = mipi_dsi_attach(dsi); >> + if (ret < 0) { >> + dev_err(dev, "Failed to attach to DSI host: %d\n", ret); >> + drm_panel_remove(&ctx->panel); >> + return ret; >> + } >> + >> + return 0; >> +} >> + >> +static void s6e3fa7_panel_remove(struct mipi_dsi_device *dsi) >> +{ >> + struct s6e3fa7_panel *ctx = mipi_dsi_get_drvdata(dsi); >> + int ret; >> + >> + ret = mipi_dsi_detach(dsi); >> + if (ret < 0) >> + dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret); >> + >> + drm_panel_remove(&ctx->panel); >> +} >> + >> +static const struct of_device_id s6e3fa7_panel_of_match[] = { >> + { .compatible = "samsung,s6e3fa7-ams559nk06" }, >> + { /* sentinel */ } >> +}; >> +MODULE_DEVICE_TABLE(of, s6e3fa7_panel_of_match); >> + >> +static struct mipi_dsi_driver s6e3fa7_panel_driver = { >> + .probe = s6e3fa7_panel_probe, >> + .remove = s6e3fa7_panel_remove, >> + .driver = { >> + .name = "panel-samsung-s6e3fa7", >> + .of_match_table = s6e3fa7_panel_of_match, >> + }, >> +}; >> +module_mipi_dsi_driver(s6e3fa7_panel_driver); >> + >> +MODULE_AUTHOR("Richard Acayan <mailingradian@xxxxxxxxx>"); >> +MODULE_DESCRIPTION("DRM driver for Samsung S6E3FA7 command mode DSI panel"); >> +MODULE_LICENSE("GPL"); > -- // Caleb (they/them)
