On Mon, 04 Mar 2024, Thomas Zimmermann <tzimmermann@xxxxxxx> wrote: > Fix builds with CONFIG_PMAC_BACKLIGHT=y. The include statement for > the backlight header has recently been removed from <linux/fb.h>. > > Reported-by: Naresh Kamboju <naresh.kamboju@xxxxxxxxxx> > Closes: https://lore.kernel.org/dri-devel/CA+G9fYsAk5TbqqxFC2W4oHLGA0CbTHMxbeq8QayFXTU75YiueA@xxxxxxxxxxxxxx/ > Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx> > Fixes: 11b4eedfc87d ("fbdev: Do not include <linux/backlight.h> in header") > Cc: Thomas Zimmermann <tzimmermann@xxxxxxx> > Cc: Jani Nikula <jani.nikula@xxxxxxxxx> > Cc: Helge Deller <deller@xxxxxx> > Cc: linux-fbdev@xxxxxxxxxxxxxxx > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx I would've added the include in arch/powerpc/include/asm/backlight.h [1], but either way is fine by me. Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx> [1] https://lore.kernel.org/r/20240304095512.742348-1-jani.nikula@xxxxxxxxx > --- > drivers/video/fbdev/chipsfb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/video/fbdev/chipsfb.c b/drivers/video/fbdev/chipsfb.c > index b80711f13df8a..b16a905588fed 100644 > --- a/drivers/video/fbdev/chipsfb.c > +++ b/drivers/video/fbdev/chipsfb.c > @@ -15,6 +15,7 @@ > */ > > #include <linux/aperture.h> > +#include <linux/backlight.h> > #include <linux/module.h> > #include <linux/kernel.h> > #include <linux/errno.h> -- Jani Nikula, Intel
