On Thu, 29 Feb 2024, "Nautiyal, Ankit K" <ankit.k.nautiyal@xxxxxxxxx> wrote: > On 2/28/2024 8:08 PM, Mitul Golani wrote: >> +enum operation_mode { >> + DP_AS_SDP_AVT_DYNAMIC_VTOTAL = 0x00, >> + DP_AS_SDP_AVT_FIXED_VTOTAL = 0x01, >> + DP_AS_SDP_FAVT_TRR_NOT_REACHED = 0x02, >> + DP_AS_SDP_FAVT_TRR_REACHED = 0x03 >> +}; > > We can drop the initialization here. For stuff that needs to match the spec it's common to include the initializations instead of relying on the auto enumeration. BR, Jani. -- Jani Nikula, Intel