On Wed, Feb 28, 2024 at 12:25 PM Hans Verkuil <hverkuil-cisco@xxxxxxxxx> wrote: > > Hi Paweł, > > On 21/02/2024 17:02, Paweł Anikiel wrote: > > Currently, .query_dv_timings() is defined as a video callback without > > a pad argument. This is a problem if the subdevice can have different > > dv timings for each pad (e.g. a DisplayPort receiver with multiple > > virtual channels). > > > > To solve this, add a pad variant of this callback which includes > > the pad number as an argument. > > So now we have two query_dv_timings ops: one for video ops, and one > for pad ops. That's not very maintainable. I would suggest switching > all current users of the video op over to the pad op. I agree it would be better if there was only one. However, I have some concerns: 1. Isn't there a problem with backwards compatibility? For example, an out-of-tree driver is likely to use this callback, which would break. I'm asking because I'm not familiar with how such API changes are handled. 2. If I do switch all current users to the pad op, I can't test those changes. Isn't that a problem? 3. Would I need to get ACK from all the driver maintainers?
