Re: [PATCH v7 29/36] drm/vc4: tests: Remove vc4_dummy_plane structure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Maxime,

On 2/27/24 10:02, Maxime Ripard wrote:
Hi Maíra,

Thanks for you reviews!

On Mon, Feb 26, 2024 at 09:29:32AM -0300, Maíra Canal wrote:
On 2/22/24 15:14, Maxime Ripard wrote:
The vc4_dummy_plane structure is an exact equivalent to vc4_plane, so we

Maybe I understood incorrectly, but isn't the vc4_dummy_plane structure
equivalent to drm_plane?

Both statements are true :)

vc4 itself uses vc4_plane to holds its plane-related content, but it
turns out that there's nothing in that structure anymore and vc4_plane
== drm_plane.

In our mock driver, we have another structure meant to store the
mock-plane-related content which doesn't have anything in it anymore,
and is thus equivalent to vc4_plane.

So, basically, vc4_dummy_plane == vc4_plane == drm_plane.

This patch is only about getting rid of vc4_dummy_plane though.

Is it clearer?


Yeah, with that pointed out, you can add my:

Reviewed-by: Maíra Canal <mcanal@xxxxxxxxxx>

Best Regards,
- Maíra

Maxime



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux