Hi, On Mon, Feb 26, 2024 at 04:48:51PM +0100, Marco Pagani wrote: > > On 2024-02-26 12:26, Maxime Ripard wrote: > > Hi, > > > > On Mon, Feb 26, 2024 at 12:00:27PM +0100, Marco Pagani wrote: > >> Set a DMA mask for the mock device to avoid warnings generated in > >> dma_map_sgtable(). > >> > >> Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx> > >> Signed-off-by: Marco Pagani <marpagan@xxxxxxxxxx> > > > > I've submitted last week this patch: > > https://lore.kernel.org/all/20240221125324.718192-1-mripard@xxxxxxxxxx/ > > > > Which should be equivalent, but fixes the issue for all users in the > > tree. > > Hi, thanks for letting me know. Fixing this issue for all DRM tests that were > using platform devices through the helpers makes perfect sense to me. I'm a > little more thoughtful about setting the mask for all KUnit tests that use fake > devices since there may be specific use cases. Just one curiosity: why setting > the default mask manually instead of using one of the dma_set_*() functions? I think the (well, mine at least) expectation is that a kunit device is a device that can be used in all reasonable contexts. Setting up the device to be able to use any DMA-related function (or functions that use a DMA-related function) makes total sense to me. But it's a discussion worth having I think, so it would make sense to raise this point with the kunit maintainers if you feel like it. Maxime
Attachment:
signature.asc
Description: PGP signature
