* Thomas Zimmermann <tzimmermann@xxxxxxx> [240227 09:16]: > I just realized the fb_deferred_io_mmap() is already exported. So please use > it instead of duplicating the code in omapdrm. > > [1] https://elixir.bootlin.com/linux/v6.7/source/drivers/video/fbdev/core/fb_defio.c#L237 Yeah I have now: static int omap_fbdev_fb_mmap(struct fb_info *info, struct vm_area_struct *vma) { vma->vm_page_prot = pgprot_writecombine(vm_get_page_prot(vma->vm_flags)); return fb_deferred_io_mmap(info, vma); } > I also noticed that omapdrm does not yet select the correct Kconfig symbols. > That can be fixed by > > 1) creating Kconfig FB_DMAMEM_HELPERS_DEFERRED that are similar to their > SYSMEM equivalent at [2]. The tokens should look like this > > configFB_DMAMEM_HELPERS_DEFERRED <https://elixir.bootlin.com/linux/latest/K/ident/CONFIG_FB_SYSMEM_HELPERS_DEFERRED> > bool > depends onFB_CORE <https://elixir.bootlin.com/linux/latest/K/ident/CONFIG_FB_CORE> > selectFB_DEFERRED_IO <https://elixir.bootlin.com/linux/latest/K/ident/CONFIG_FB_DEFERRED_IO> > selectFB_DMAMEM_HELPERS <https://elixir.bootlin.com/linux/latest/K/ident/CONFIG_FB_SYSMEM_HELPERS> OK > 2) and selecting it instead of FB_DMAMEM_HELPERS under omapdrm's Kconfig > symbol. OK Regards, Tony > [2] https://elixir.bootlin.com/linux/latest/source/drivers/video/fbdev/core/Kconfig#L147
