Re: [PATCH 0/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 23/02/2024 13:51, Johan Hovold wrote:
On Fri, Feb 23, 2024 at 12:03:10PM +0100, Neil Armstrong wrote:
On 23/02/2024 12:02, Neil Armstrong wrote:
Hi,

On Sat, 17 Feb 2024 16:02:22 +0100, Johan Hovold wrote:
Starting with 6.8-rc1 the internal display sometimes fails to come up on
machines like the Lenovo ThinkPad X13s and the logs indicate that this
is due to a regression in the DRM subsystem [1].

This series fixes a race in the pmic_glink_altmode driver which was
exposed / triggered by the transparent DRM bridges rework that went into
6.8-rc1 and that manifested itself as a bridge failing to attach and
sometimes triggering a NULL-pointer dereference.

[...]

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-fixes)

[1/6] drm/bridge: aux-hpd: fix OF node leaks
        https://cgit.freedesktop.org/drm/drm-misc/commit/?id=9ee485bdda68d6d3f5728cbe3150eb9013d7d22b
[2/6] drm/bridge: aux-hpd: separate allocation and registration
        (no commit info)
[3/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free
        (no commit info)
[4/6] soc: qcom: pmic_glink: Fix boot when QRTR=m
        (no commit info)
[5/6] phy: qcom-qmp-combo: fix drm bridge registration
        (no commit info)
[6/6] phy: qcom-qmp-combo: fix type-c switch registration
        (no commit info)


To clarify, I only applied patch 1 to drm-misc-fixes

Ok, but can you please not do that? :)

These patches should go in through the same tree to avoid conflicts.

I discussed this with Bjorn and Dmitry the other day and the conclusion
was that it was easiest to take all of these through DRM.

I only applied patch 1, which is a standalone fix and goes into a separate tree,
for the next patches it would be indeed simpler for them to go via drm-misc when
they are properly acked.

Neil


With Vinod acking the PHY patches, I believe you have what you need to
merge the whole series now?

Johan




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux