… > Specifically, the dp-hpd bridge is currently registered before all > resources have been acquired which means that it can also be > deregistered on probe deferrals. > > In the meantime there is a race window where the new aux bridge driver > (or PHY driver previously) may have looked up the dp-hpd bridge and > stored a (non-reference-counted) pointer to the bridge which is about to > be deallocated. … I got the impression that the change description can be improved another bit. 1. Will any additional imperative wordings become helpful? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.8-rc5#n94 … > +++ b/drivers/soc/qcom/pmic_glink_altmode.c > @@ -76,7 +76,7 @@ struct pmic_glink_altmode_port { > > struct work_struct work; > > - struct device *bridge; > + struct auxiliary_device *bridge; > > enum typec_orientation orientation; > u16 svid; … 2. How do you think about to stress such a data type adjustment? Regards, Markus
