On Thu, 08 Feb 2024 17:20:40 +0200, Dmitry Baryshkov wrote: > The dpu_encoder_phys_ops::atomic_mode_set() callback is mostly > redundant. Implementations only set the IRQ indices there. Move > statically allocated IRQs to dpu_encoder_phys_*_init() and set > dynamically allocated IRQs in the irq_enable() callback. > > The writeback backend of the dpu_encoder is the only user of the > dpu_encoder_phys_ops::atomic_check() callback. Move corresponding code > to the DPU's drm_writeback_connector implementation (dpu_writeback.c) > and drop corresponding callback code. > > [...] Applied, thanks! [1/5] drm/msm/dpu: split irq_control into irq_enable and _disable https://gitlab.freedesktop.org/lumag/msm/-/commit/c6f60037bfa0 [2/5] drm/msm/dpu: split _dpu_encoder_resource_control_helper() https://gitlab.freedesktop.org/lumag/msm/-/commit/ca8c1fd3eed8 [3/5] drm/msm/dpu: drop dpu_encoder_phys_ops.atomic_mode_set https://gitlab.freedesktop.org/lumag/msm/-/commit/d13f638c9b88 [4/5] drm/msm/dpu: move writeback's atomic_check to dpu_writeback.c https://gitlab.freedesktop.org/lumag/msm/-/commit/71174f362d67 [5/5] drm/msm/dpu: drop dpu_encoder_phys_ops::atomic_check() https://gitlab.freedesktop.org/lumag/msm/-/commit/b0b621f41b45 Best regards, -- Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>