On Fri, 9 Feb 2024 at 20:58, Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> wrote: > > On Fri, 9 Feb 2024 at 20:44, Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> wrote: > > > > > > > > On 2/8/2024 7:01 AM, Dmitry Baryshkov wrote: > > > Existing MDP5 devices have slightly different bindings. The main > > > register region is called `mdp_phys' instead of `mdp'. Also vbif > > > register regions are a part of the parent, MDSS device. Add support for > > > handling this binding differences. > > > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > > --- > > > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 98 ++++++++++++++++++++++++++------- > > > drivers/gpu/drm/msm/msm_drv.h | 3 + > > > drivers/gpu/drm/msm/msm_io_utils.c | 13 +++++ > > > 3 files changed, 93 insertions(+), 21 deletions(-) > > > > > > > I thought we had agreed on a quite version of msm_ioremap_mdss for > > vbif_nrt_phys? > > > > Anyway, its not something to block this change. Hence, > > Excuse me, I'll fix it when applying, if I don't forget. I took another glance. The msm_ioremap_mdss is already quiet (it is not printing warnings if the resource is not present), so this should be fine by default. But I'll make a note that we might be able to replace most of msm_ioremap functions with the standard devm ioremap functions. -- With best wishes Dmitry
