On Thursday, February 15, 2024 2:31:37 PM CET Linus Walleij wrote:
> On Tue, Feb 13, 2024 at 7:13 PM Duje Mihanović <duje.mihanovic@xxxxxxxx>
wrote:
> > LEDS_EXPRESSWIRE depends on GPIOLIB, and so must anything selecting it:
> >
> > WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE
> >
> > Depends on [n]: NEW_LEDS [=y] && GPIOLIB [=n]
> > Selected by [m]:
> > - BACKLIGHT_KTD2801 [=m] && HAS_IOMEM [=y] && BACKLIGHT_CLASS_DEVICE
[=m]
> >
> > Fixes: 66c76c1cd984 ("backlight: Add Kinetic KTD2801 backlight support")
> > Signed-off-by: Duje Mihanović <duje.mihanovic@xxxxxxxx>
>
> Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> Technically you can also select GPIOLIB, because it is available on
> all platforms, so it may be easier for users, but then you never know
> which GPIOs you get in practice.
Now that I think of it, wouldn't that be the better solution? I opted for
"depends on" only because Arnd did the same in his KTD2692 patch, but if
select is better (and it seems to be for users) then I'd go for that in both
patches.
Regards,
--
Duje
