On 2/12/2024 1:55 PM, Rob Clark wrote:
From: Rob Clark <robdclark@xxxxxxxxxxxx>
DRM_MODESET_LOCK_ALL_BEGIN() has a hidden trap-door (aka retry loop),
which means we can't rely too much on variable initializers.
Fixes: 6e455f5dcdd1 ("drm/crtc: fix uninitialized variable use")
Signed-off-by: Rob Clark <robdclark@xxxxxxxxxxxx>
---
I have mixed feelings about DRM_MODESET_LOCK_ALL_BEGIN() (and friends)
magic. On one hand it simplifies the deadlock/back dance. OTOH it
conceals a nasty sharp edge. Maybe it is better to have the complicated
restart path a bit more explicit, like it was originally.
drivers/gpu/drm/drm_crtc.c | 1 +
1 file changed, 1 insertion(+)
Nice catch !!
Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
