Re: [PATCH drm-misc-next] drm/xe: Fix a missing argument to drm_err_printer

[Jani Nikula <jani.nikula@xxxxxxxxx>]

On Mon, 12 Feb 2024, Thomas Hellström <thomas.hellstrom@xxxxxxxxxxxxxxx> wrote:
> The indicated commit below added a device argument to the
> function, but there was a call in the xe driver that was
> not properly changed.

Aww, crap. Looks like my drm-misc-next configs don't have xe enabled.

Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>

> Fixes: 5e0c04c8c40b ("drm/print: make drm_err_printer() device specific by using drm_err()")
> Cc: Jani Nikula <jani.nikula@xxxxxxxxx>
> Cc: Luca Coelho <luciano.coelho@xxxxxxxxx>
> Cc: Maxime Ripard <mripard@xxxxxxxxxx>
> Signed-off-by: Thomas Hellström <thomas.hellstrom@xxxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
> index 7eef23a00d77..d42645fdfc02 100644
> --- a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
> +++ b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
> @@ -314,7 +314,7 @@ int xe_gt_tlb_invalidation_wait(struct xe_gt *gt, int seqno)
>  {
>  	struct xe_device *xe = gt_to_xe(gt);
>  	struct xe_guc *guc = &gt->uc.guc;
> -	struct drm_printer p = drm_err_printer(__func__);
> +	struct drm_printer p = drm_err_printer(&xe->drm, __func__);
>  	int ret;
>  
>  	/*

-- 
Jani Nikula, Intel