> -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Imre > Deak > Sent: Tuesday, January 23, 2024 3:59 PM > To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx > Subject: [PATCH 17/19] drm/i915/dp: Call intel_dp_sync_state() always for DDI > DP encoders > > A follow-up change will need to resume DP tunnels during system resume, so call > intel_dp_sync_state() always for DDI encoders, so this function can resume the > tunnels for all DP connectors. Looks good to me. Reviewed-by: Uma Shankar <uma.shankar@xxxxxxxxx> > Signed-off-by: Imre Deak <imre.deak@xxxxxxxxx> > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c > b/drivers/gpu/drm/i915/display/intel_ddi.c > index aa6e7da08fbce..1e26e62b82d48 100644 > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > @@ -4131,7 +4131,7 @@ static void intel_ddi_sync_state(struct intel_encoder > *encoder, > intel_tc_port_sanitize_mode(enc_to_dig_port(encoder), > crtc_state); > > - if (crtc_state && intel_crtc_has_dp_encoder(crtc_state)) > + if (intel_encoder_is_dp(encoder)) > intel_dp_sync_state(encoder, crtc_state); } > > -- > 2.39.2