Re: [PATCH RESEND v3 04/15] drm/msm/dp: inline dp_power_(de)init

[Kuogee Hsieh <quic_khsieh@xxxxxxxxxxx>]

On 1/26/2024 10:26 AM, Dmitry Baryshkov wrote:
> In preparation to cleanup of the dp_power module, inline dp_power_init()
> and dp_power_deinit() functions, which are now just turning the clocks
> on and off.
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
Tested-by: Kuogee Hsieh <quic_khsieh@xxxxxxxxxxx>
Reviewed-by: Kuogee Hsieh <quic_khsieh@xxxxxxxxxxx>
> ---
>   drivers/gpu/drm/msm/dp/dp_display.c |  4 ++--
>   drivers/gpu/drm/msm/dp/dp_power.c   | 10 ----------
>   drivers/gpu/drm/msm/dp/dp_power.h   | 21 ---------------------
>   3 files changed, 2 insertions(+), 33 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
> index 67b48f0a6c83..8cd18705740f 100644
> --- a/drivers/gpu/drm/msm/dp/dp_display.c
> +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> @@ -434,7 +434,7 @@ static void dp_display_host_init(struct dp_display_private *dp)
>   		dp->dp_display.connector_type, dp->core_initialized,
>   		dp->phy_initialized);
>   
> -	dp_power_init(dp->power);
> +	dp_power_clk_enable(dp->power, DP_CORE_PM, true);
>   	dp_ctrl_reset_irq_ctrl(dp->ctrl, true);
>   	dp_aux_init(dp->aux);
>   	dp->core_initialized = true;
> @@ -448,7 +448,7 @@ static void dp_display_host_deinit(struct dp_display_private *dp)
>   
>   	dp_ctrl_reset_irq_ctrl(dp->ctrl, false);
>   	dp_aux_deinit(dp->aux);
> -	dp_power_deinit(dp->power);
> +	dp_power_clk_enable(dp->power, DP_CORE_PM, false);
>   	dp->core_initialized = false;
>   }
>   
> diff --git a/drivers/gpu/drm/msm/dp/dp_power.c b/drivers/gpu/drm/msm/dp/dp_power.c
> index b095a5b47c8b..f49e3aede308 100644
> --- a/drivers/gpu/drm/msm/dp/dp_power.c
> +++ b/drivers/gpu/drm/msm/dp/dp_power.c
> @@ -152,16 +152,6 @@ int dp_power_client_init(struct dp_power *dp_power)
>   	return dp_power_clk_init(power);
>   }
>   
> -int dp_power_init(struct dp_power *dp_power)
> -{
> -	return dp_power_clk_enable(dp_power, DP_CORE_PM, true);
> -}
> -
> -int dp_power_deinit(struct dp_power *dp_power)
> -{
> -	return dp_power_clk_enable(dp_power, DP_CORE_PM, false);
> -}
> -
>   struct dp_power *dp_power_get(struct device *dev, struct dp_parser *parser)
>   {
>   	struct dp_power_private *power;
> diff --git a/drivers/gpu/drm/msm/dp/dp_power.h b/drivers/gpu/drm/msm/dp/dp_power.h
> index 55ada51edb57..eb836b5aa24a 100644
> --- a/drivers/gpu/drm/msm/dp/dp_power.h
> +++ b/drivers/gpu/drm/msm/dp/dp_power.h
> @@ -22,27 +22,6 @@ struct dp_power {
>   	bool stream_clks_on;
>   };
>   
> -/**
> - * dp_power_init() - enable power supplies for display controller
> - *
> - * @power: instance of power module
> - * return: 0 if success or error if failure.
> - *
> - * This API will turn on the regulators and configures gpio's
> - * aux/hpd.
> - */
> -int dp_power_init(struct dp_power *power);
> -
> -/**
> - * dp_power_deinit() - turn off regulators and gpios.
> - *
> - * @power: instance of power module
> - * return: 0 for success
> - *
> - * This API turns off power and regulators.
> - */
> -int dp_power_deinit(struct dp_power *power);
> -
>   /**
>    * dp_power_clk_status() - display controller clocks status
>    *