Re: [PATCH RESEND v3 01/15] drm/msm/dp: drop unused parser definitions

[Kuogee Hsieh <quic_khsieh@xxxxxxxxxxx>]

On 1/26/2024 10:26 AM, Dmitry Baryshkov wrote:
> Drop several unused and obsolete definitions from the dp_parser module.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
Tested-by: Kuogee Hsieh <quic_khsieh@xxxxxxxxxxx>
Reviewed-by: Kuogee Hsieh <quic_khsieh@xxxxxxxxxxx>
> ---
>   drivers/gpu/drm/msm/dp/dp_parser.h | 46 --------------------------------------
>   1 file changed, 46 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_parser.h b/drivers/gpu/drm/msm/dp/dp_parser.h
> index 1f068626d445..90a2cdbbe344 100644
> --- a/drivers/gpu/drm/msm/dp/dp_parser.h
> +++ b/drivers/gpu/drm/msm/dp/dp_parser.h
> @@ -12,7 +12,6 @@
>   
>   #include "msm_drv.h"
>   
> -#define DP_LABEL "MDSS DP DISPLAY"
>   #define DP_MAX_PIXEL_CLK_KHZ	675000
>   #define DP_MAX_NUM_DP_LANES	4
>   #define DP_LINK_RATE_HBR2	540000 /* kbytes */
> @@ -21,7 +20,6 @@ enum dp_pm_type {
>   	DP_CORE_PM,
>   	DP_CTRL_PM,
>   	DP_STREAM_PM,
> -	DP_PHY_PM,
>   	DP_MAX_PM
>   };
>   
> @@ -43,28 +41,10 @@ static inline const char *dp_parser_pm_name(enum dp_pm_type module)
>   	case DP_CORE_PM:	return "DP_CORE_PM";
>   	case DP_CTRL_PM:	return "DP_CTRL_PM";
>   	case DP_STREAM_PM:	return "DP_STREAM_PM";
> -	case DP_PHY_PM:		return "DP_PHY_PM";
>   	default:		return "???";
>   	}
>   }
>   
> -/**
> - * struct dp_display_data  - display related device tree data.
> - *
> - * @ctrl_node: referece to controller device
> - * @phy_node:  reference to phy device
> - * @is_active: is the controller currently active
> - * @name: name of the display
> - * @display_type: type of the display
> - */
> -struct dp_display_data {
> -	struct device_node *ctrl_node;
> -	struct device_node *phy_node;
> -	bool is_active;
> -	const char *name;
> -	const char *display_type;
> -};
> -
>   /**
>    * struct dp_ctrl_resource - controller's IO related data
>    *
> @@ -77,28 +57,6 @@ struct dp_io {
>   	union phy_configure_opts phy_opts;
>   };
>   
> -/**
> - * struct dp_pinctrl - DP's pin control
> - *
> - * @pin: pin-controller's instance
> - * @state_active: active state pin control
> - * @state_hpd_active: hpd active state pin control
> - * @state_suspend: suspend state pin control
> - */
> -struct dp_pinctrl {
> -	struct pinctrl *pin;
> -	struct pinctrl_state *state_active;
> -	struct pinctrl_state *state_hpd_active;
> -	struct pinctrl_state *state_suspend;
> -};
> -
> -/* Regulators for DP devices */
> -struct dp_reg_entry {
> -	char name[32];
> -	int enable_load;
> -	int disable_load;
> -};
> -
>   struct dss_module_power {
>   	unsigned int num_clk;
>   	struct clk_bulk_data *clocks;
> @@ -109,16 +67,12 @@ struct dss_module_power {
>    *
>    * @pdev: platform data of the client
>    * @mp: gpio, regulator and clock related data
> - * @pinctrl: pin-control related data
> - * @disp_data: controller's display related data
>    * @parse: function to be called by client to parse device tree.
>    */
>   struct dp_parser {
>   	struct platform_device *pdev;
>   	struct dss_module_power mp[DP_MAX_PM];
> -	struct dp_pinctrl pinctrl;
>   	struct dp_io io;
> -	struct dp_display_data disp_data;
>   	u32 max_dp_lanes;
>   	u32 max_dp_link_rate;
>   	struct drm_bridge *next_bridge;