On Mon, Jan 22, 2024 at 06:26:04PM +0100, Duje Mihanović wrote: > On Monday, January 22, 2024 5:57:53 PM CET Duje Mihanović wrote: > > On Monday, January 22, 2024 5:50:11 PM CET Daniel Thompson wrote: > > > AFAICT nothing will inhibit setting GPIOLIB so allyes- and allmodconfig > > > builds will always end up with GPIOLIB enabled. If we are happy to > > > select it then I think that is enough! > > > > In that case I guess I'll just make it select GPIOLIB. > > Nevermind that, it'll have to be 'depends on' after all: > > drivers/gpio/Kconfig:6:error: recursive dependency detected! > drivers/gpio/Kconfig:6: symbol GPIOLIB is selected by LEDS_EXPRESSWIRE > drivers/leds/Kconfig:184: symbol LEDS_EXPRESSWIRE depends on NEW_LEDS Can this dependency could be broken by declaring LEDS_EXPRESSWIRE at the top (or bottom) of the KConfig file (it's an option without a UI and does not need to be within the if NEW_LEDS block). I'm aware this kind of change could provoke an argument about which sub-system the expresswire code should live in... but I think it's a worthwhile change anyway! We shouldn't need NEW_LEDS for this. Daniel.
