On Sun, Jan 21, 2024 at 03:49:23PM +0200, Andy Shevchenko wrote: > On Mon, Jan 15, 2024 at 09:22:19AM +0100, Javier Martinez Canillas wrote: > > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> writes: > > ... > > > > + {} > > > > While at it, maybe add the { /* sentinel */ } convention to the last entry ? > > Maybe. Is it a common for this subsystem? I'd answer that slightly differently. Backlight does not aspire to be special regarding this sort of thing. If this pattern is becoming common within the rest of the kernel then its absolutely fine to use it here! There are certainly backlights that use this convention... although they are not yet the majority. Daniel.