On Sunday, January 21, 2024 3:35:46 PM CET Linus Walleij wrote: > > +extern void expresswire_power_off(struct expresswire_common_props *props); > > +extern void expresswire_enable(struct expresswire_common_props *props); > > +extern void expresswire_start(struct expresswire_common_props *props); > > +extern void expresswire_end(struct expresswire_common_props *props); > > +extern void expresswire_set_bit(struct expresswire_common_props *props, > > bool bit); > I would skip the keyword "extern" since it is default I think even > checkpatch complains about it these days? Doesn't seem to, I tried it myself: $ git format-patch HEAD~3 0001-leds-ktd2692-move-ExpressWire-code-to-library.patch 0002-dt-bindings-backlight-add-Kinetic-KTD2801-binding.patch 0003-backlight-Add-Kinetic-KTD2801-backlight-support.patch $ ./scripts/checkpatch.pl 0001-leds-ktd2692-move-ExpressWire-code-to- library.patch total: 0 errors, 0 warnings, 291 lines checked 0001-leds-ktd2692-move-ExpressWire-code-to-library.patch has no obvious style problems and is ready for submission. I'll keep that in mind if a v4 is needed though. Regards, -- Duje
