Hi Laurent, Thank you for the reply. > Date: Wed, 17 Jan 2024 16:24:20 +0200 > From: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > To: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx> > Cc: Anatoliy Klymenko <anatoliy.klymenko@xxxxxxx>, > maarten.lankhorst@xxxxxxxxxxxxxxx, mripard@xxxxxxxxxx, > tzimmermann@xxxxxxx, airlied@xxxxxxxxx, daniel@xxxxxxxx, > michal.simek@xxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/4] drm: xlnx: zynqmp_dpsub: Make drm bridge > discoverable > Message-ID: <20240117142420.GE17920@xxxxxxxxxxxxxxxxxxxxxxxxxx> > Content-Type: text/plain; charset=utf-8 > > On Wed, Jan 17, 2024 at 04:06:31PM +0200, Tomi Valkeinen wrote: > > On 13/01/2024 01:42, Anatoliy Klymenko wrote: > > > Assign device of node to bridge prior registering it. This will make > > > said bridge discoverable by separate crtc driver. > > > > I think a few words on why this is needed (and why it wasn't needed > > before) would be nice. > > > > Other than that: > > > > Reviewed-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx> > > Agreed. With a better commit message, > Sure, I will update commit message in the next version. > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > > > Signed-off-by: Anatoliy Klymenko <anatoliy.klymenko@xxxxxxx> > > > --- > > > drivers/gpu/drm/xlnx/zynqmp_dp.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c > > > b/drivers/gpu/drm/xlnx/zynqmp_dp.c > > > index a0606fab0e22..d60b7431603f 100644 > > > --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c > > > +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c > > > @@ -1721,6 +1721,7 @@ int zynqmp_dp_probe(struct zynqmp_dpsub > *dpsub) > > > bridge->ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID > > > | DRM_BRIDGE_OP_HPD; > > > bridge->type = DRM_MODE_CONNECTOR_DisplayPort; > > > + bridge->of_node = dp->dev->of_node; > > > dpsub->bridge = bridge; > > > > > > /* > > -- > Regards, > > Laurent Pinchart > > Thank you, Anatoliy
