Re: [PATCH 2/3] video/cmdline: Hide __video_get_options() behind CONFIG_FB_CORE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Thomas,

kernel test robot noticed the following build errors:

[auto build test ERROR on 05b317e8457c8e2bd1a797c9440ec07b7f341584]

url:    https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/video-cmdline-Introduce-CONFIG_VIDEO-for-video-parameter/20240115-181419
base:   05b317e8457c8e2bd1a797c9440ec07b7f341584
patch link:    https://lore.kernel.org/r/20240115100939.21562-3-tzimmermann%40suse.de
patch subject: [PATCH 2/3] video/cmdline: Hide __video_get_options() behind CONFIG_FB_CORE
config: i386-randconfig-011-20240118 (https://download.01.org/0day-ci/archive/20240118/202401180531.K8mdBrAu-lkp@xxxxxxxxx/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240118/202401180531.K8mdBrAu-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401180531.K8mdBrAu-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

   drivers/video/fbdev/core/fb_cmdline.c: In function 'fb_get_options':
>> drivers/video/fbdev/core/fb_cmdline.c:45:19: error: implicit declaration of function '__video_get_options'; did you mean 'video_get_options'? [-Werror=implicit-function-declaration]
      45 |         enabled = __video_get_options(name, &options, is_of);
         |                   ^~~~~~~~~~~~~~~~~~~
         |                   video_get_options
   cc1: some warnings being treated as errors


vim +45 drivers/video/fbdev/core/fb_cmdline.c

367221793d4796 Thomas Zimmermann 2023-02-09  23  
ea6763c104c93a Daniel Vetter     2014-08-06  24  /**
ea6763c104c93a Daniel Vetter     2014-08-06  25   * fb_get_options - get kernel boot parameters
ea6763c104c93a Daniel Vetter     2014-08-06  26   * @name:   framebuffer name as it would appear in
ea6763c104c93a Daniel Vetter     2014-08-06  27   *          the boot parameter line
ea6763c104c93a Daniel Vetter     2014-08-06  28   *          (video=<name>:<options>)
ea6763c104c93a Daniel Vetter     2014-08-06  29   * @option: the option will be stored here
ea6763c104c93a Daniel Vetter     2014-08-06  30   *
73ce73c30ba9ae Thomas Zimmermann 2023-02-09  31   * The caller owns the string returned in @option and is
73ce73c30ba9ae Thomas Zimmermann 2023-02-09  32   * responsible for releasing the memory.
73ce73c30ba9ae Thomas Zimmermann 2023-02-09  33   *
ea6763c104c93a Daniel Vetter     2014-08-06  34   * NOTE: Needed to maintain backwards compatibility
ea6763c104c93a Daniel Vetter     2014-08-06  35   */
ea6763c104c93a Daniel Vetter     2014-08-06  36  int fb_get_options(const char *name, char **option)
ea6763c104c93a Daniel Vetter     2014-08-06  37  {
93604a5ade3a02 Thomas Zimmermann 2023-02-09  38  	const char *options = NULL;
93604a5ade3a02 Thomas Zimmermann 2023-02-09  39  	bool is_of = false;
93604a5ade3a02 Thomas Zimmermann 2023-02-09  40  	bool enabled;
cedaf7cddd7339 Thomas Zimmermann 2023-02-09  41  
93604a5ade3a02 Thomas Zimmermann 2023-02-09  42  	if (name)
93604a5ade3a02 Thomas Zimmermann 2023-02-09  43  		is_of = strncmp(name, "offb", 4);
ea6763c104c93a Daniel Vetter     2014-08-06  44  
93604a5ade3a02 Thomas Zimmermann 2023-02-09 @45  	enabled = __video_get_options(name, &options, is_of);

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux