Hi, On Wed, Jan 17, 2024 at 11:39 AM Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> wrote: > > On Wed, Jan 17, 2024 at 10:35 AM Douglas Anderson <dianders@xxxxxxxxxxxx> wrote: > > > > After commit 26db46bc9c67 ("drm/bridge: parade-ps8640: Ensure bridge > > is suspended in .post_disable()"), if we hit the error case in > > ps8640_aux_transfer() then we return without dropping the mutex. Fix > > this oversight. > > > > Fixes: 26db46bc9c67 ("drm/bridge: parade-ps8640: Ensure bridge is suspended in .post_disable()") > > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > > --- > > Sorry for missing this in my review! :( Given that this is really > > simple and I'd rather the buggy commit not be there for long, if I can > > get a quick Reviewed-by tag on this patch I'll land it without the > > typical stewing period. > > > > Reviewed-by: Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> Thanks! I've pushed this to avoid the breakage. If any additional follow up comes up I'm happy to post additional patches. a20f1b02bafc drm/bridge: parade-ps8640: Make sure we drop the AUX mutex in the error case -Doug