Hi Vignesh, On Wed, 10 Jan 2024 at 10:47, Vignesh Raman <vignesh.raman@xxxxxxxxxxxxx> wrote: > On 09/01/24 19:08, Daniel Stone wrote: > > A better sequencing would be something like: > > 1. add ANX7625 config > > 2. refactor _existing_ MTK display jobs to use YAML includes, change > > the existing job name, and rename the existing xfail set, remove > > IGT_FORCE_DRIVER from the script since it's now set by the job > > 3. add MTK Panfrost+PVR GPU jobs with new xfails, add xfail entry to > > MAINTAINERS > > 4+5: same as 2+3 but for Amlogic > > 6+7: same as 2+3 but for Rockchip > > > > Then the separate rename/update xfail commits just disappear, as does > > the removal of IGT_FORCE_DRIVER, because it's just done incrementally > > as part of the commits which change the related functionality. It's > > extremely important that every change can work standalone, instead of > > introducing intermediate breakage which is only fixed in later commits > > in the series. > > Thank you for reviewing the patches. I agree, will follow this sequence > and send a v2 version. Alongside Rob's patch to add msm-specific tests to the runlist, we'd need to add the Panfrost-specific tests. Whilst we're here, we might as well add the vc4/v3d/etnaviv/lima tests so they can use it in future. Panfrost should also skip kms_.* tests - since it's not a KMS driver, it can't run the KMS tests, so there's no point in trying. Cheers, Daniel
