On Thu, 11 Jan 2024 at 01:01, Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> wrote: > > > > On 10/9/2023 1:57 PM, Dmitry Baryshkov wrote: > > The MSM DSI driver has dropped support for calling > > mdp_kms_funcs::set_split_display() callback. Drop corresponding callback > > from the mdp5 driver together with the rest of the infrastructure. > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > --- > > .../gpu/drm/msm/disp/mdp5/mdp5_cmd_encoder.c | 42 ------------------- > > drivers/gpu/drm/msm/disp/mdp5/mdp5_encoder.c | 42 ------------------- > > drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 14 ------- > > drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.h | 9 ---- > > drivers/gpu/drm/msm/msm_kms.h | 4 -- > > 5 files changed, 111 deletions(-) > > > > The programming inside the set_split_display() looks right from what i > see, so whenever (if at all) bonded_dsi is implemented for mdp5, this > will remain intact. Its just that there are no consumers left for > set_split_display anymore so its dead code. If someone wants to add that > support, I guess they have to start by reverting this commit first. If > thats the plan and agreement, Either by reverting this commit or by introducing a wrapper like the one present in dpu_encoder_virt. > > Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> -- With best wishes Dmitry
