On 10/9/2023 1:57 PM, Dmitry Baryshkov wrote:
Since the commit 8b03ad30e314 ("drm/msm/dsi: Use one connector for dual
DSI mode"), the second DSI host in the bonded pair will not be
associated with the encoder and will not get the bridges, thus making
condition in msm_dsi_manager_set_split_display() always false.
You are referring to the other_dsi->external_bridge condition here right?
if (other_dsi && other_dsi->external_bridge &&
kms->funcs->set_split_display)
Technically that change broke bonded DSI support in the MDP5 driver. But
since nobody complained in the last 5.5 years, it seems that nobody
cares enough.
Unfortunate but true.
I dont have a problem with this unless someone wants to use split
display with MDP5 and wants to fix this path.
Drop the msm_dsi_manager_set_split_display() completely and stop calling
the set_split_display() KMS callback. Also remove the
msm_dsi::external_bridge field which was only used by the mentioned
function.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
---
drivers/gpu/drm/msm/dsi/dsi.h | 5 ----
drivers/gpu/drm/msm/dsi/dsi_manager.c | 35 ---------------------------
2 files changed, 40 deletions(-)
Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
