On 08/01/24 07:15, Maxime Ripard wrote: > Hi Arthur, > > On Fri, Jan 05, 2024 at 01:35:08PM -0300, Arthur Grillo wrote: >> diff --git a/drivers/gpu/drm/vkms/vkms_formats.c b/drivers/gpu/drm/vkms/vkms_formats.c >> index b654b6661a20..11df990a0fa9 100644 >> --- a/drivers/gpu/drm/vkms/vkms_formats.c >> +++ b/drivers/gpu/drm/vkms/vkms_formats.c >> @@ -440,3 +440,7 @@ void *get_pixel_write_function(u32 format) >> return NULL; >> } >> } >> + >> +#ifdef CONFIG_DRM_VKMS_KUNIT_TESTS >> +#include "tests/vkms_format_test.c" >> +#endif > > I assume this is due to testing a static function? Yeah, you're right. > > If so, the preferred way nowadays is to use EXPORT_SYMBOL_IF_KUNIT or > EXPORT_SYMBOL_FOR_TESTS_ONLY if it's DRM/KMS only. Oh, I didn't know about that. I think I will use EXPORT_SYMBOL_IF_KUNIT as you can use VISIBLE_IF_KUNIT to maintain the function static if the test is not used. ~Arthur Grillo > > Maxime
