On Sat, Jan 06, 2024 at 07:31:18PM +0530, Dipam Turkar wrote:
> ---
> drivers/gpu/drm/tests/drm_connector_test.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
You're missing your commit message, Signed-off-by and version changes here.
> diff --git a/drivers/gpu/drm/tests/drm_connector_test.c b/drivers/gpu/drm/tests/drm_connector_test.c
> index c66aa2dc8d9d..aad63839b5e5 100644
> --- a/drivers/gpu/drm/tests/drm_connector_test.c
> +++ b/drivers/gpu/drm/tests/drm_connector_test.c
> @@ -4,6 +4,9 @@
> */
>
> #include <drm/drm_connector.h>
> +#include <drm/drm_device.h>
> +#include <drm/drm_drv.h>
> +#include <drm/drm_kunit_helpers.h>
>
> #include <kunit/test.h>
>
> @@ -58,10 +61,27 @@ static void drm_test_get_tv_mode_from_name_truncated(struct kunit *test)
> KUNIT_EXPECT_LT(test, ret, 0);
> };
>
> +static void drm_test_mode_create_dvi_i_properties(struct kunit *test)
> +{
> + struct drm_device *drm;
> + struct device *dev;
> +
> + dev = drm_kunit_helper_alloc_device(test);
> + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, dev);
> +
> + drm = __drm_kunit_helper_alloc_drm_device(test, dev, sizeof(*drm), 0, DRIVER_MODESET);
> + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, drm);
> +
> + KUNIT_EXPECT_EQ(test, drm_mode_create_dvi_i_properties(drm), 0);
> + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, drm->mode_config.dvi_i_select_subconnector_property);
> + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, drm->mode_config.dvi_i_subconnector_property);
> +}
> +
> static struct kunit_case drm_get_tv_mode_from_name_tests[] = {
> KUNIT_CASE_PARAM(drm_test_get_tv_mode_from_name_valid,
> drm_get_tv_mode_from_name_valid_gen_params),
> KUNIT_CASE(drm_test_get_tv_mode_from_name_truncated),
> + KUNIT_CASE(drm_test_mode_create_dvi_i_properties),
And you still don't have the other test we talked about
Maxime
Attachment:
signature.asc
Description: PGP signature
