Re: [PATCH 3/6] drm/bridge: imx: imx-ldb-helper: Use dev_err_probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Francesco,

thanks for the feedback.

Am Donnerstag, 4. Januar 2024, 20:28:08 CET schrieb Francesco Dolcini:
> On Thu, Jan 04, 2024 at 08:20:37PM +0100, Francesco Dolcini wrote:
> > On Mon, Dec 18, 2023 at 11:57:15AM +0100, Alexander Stein wrote:
> > > This simplifies the code and gives additional information upon deferral.
> > > 
> > > Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> > 
> > Reviewed-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
> 
> mumble, looking at this more closely with your change you stop using
> the print wrapper from drm_print.h. Probably a more generic solution is
> needed there?

You are talking about DRM_DEV_ERROR()? Well, it's deprecated, see [1]. Instead 
of dev_err, I rather use dev_err_probe because this is what we want to use 
here.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/
include/drm/drm_print.h#n365
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/






[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux