Hi Am 05.01.24 um 11:41 schrieb Jocelyn Falempe:
Hi, On 05/01/2024 09:25, Thomas Zimmermann wrote:I/O video memory for the framebuffer supports write-combine caching mode. Simplify the driver's code that sets up the caching mode. * Map video memory with ioremap_wc(), which automatically sets up the PAT entry with write-combine caching. * Remove the now obsolete call to devm_arch_io_reserve_memtype_wc(). It is only required to mmap the video memory to user space, which the driver doesn't do. * According to the PAT documentation, arch_phys_wc_add() is best called after remapping I/O memory, so move it after ioremap.Thanks a lot for taking some time to look at the latency issue. This looks good to me. Reviewed-by: Jocelyn Falempe <jfalempe@xxxxxxxxxx>
Thanks a lot for the review. I'll send out a similar patch for ast, which has the same issues.
Best regards Thomas -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)
Attachment:
OpenPGP_signature.asc
Description: OpenPGP digital signature
