From: Dafna Hirschfeld <dhirschfeld@xxxxxxxxx> print err log if eventfd_signal return val is not 1 as expected. Signed-off-by: Dafna Hirschfeld <dhirschfeld@xxxxxxxxx> Reviewed-by: Oded Gabbay <ogabbay@xxxxxxxxxx> Signed-off-by: Oded Gabbay <ogabbay@xxxxxxxxxx> --- drivers/accel/habanalabs/common/device.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/accel/habanalabs/common/device.c b/drivers/accel/habanalabs/common/device.c index a365791a9f5c..e81ccafddfb3 100644 --- a/drivers/accel/habanalabs/common/device.c +++ b/drivers/accel/habanalabs/common/device.c @@ -2043,13 +2043,19 @@ int hl_device_cond_reset(struct hl_device *hdev, u32 flags, u64 event_mask) return hl_device_reset(hdev, flags | HL_DRV_RESET_HARD); } -static void hl_notifier_event_send(struct hl_notifier_event *notifier_event, u64 event_mask) +static void hl_notifier_event_send(struct hl_device *hdev, + struct hl_notifier_event *notifier_event, u64 event_mask) { + u64 n; + mutex_lock(¬ifier_event->lock); notifier_event->events_mask |= event_mask; - if (notifier_event->eventfd) - eventfd_signal(notifier_event->eventfd, 1); + if (notifier_event->eventfd) { + n = eventfd_signal(notifier_event->eventfd, 1); + if (n != 1) + dev_err(hdev->dev, "eventfd signal failed, incremented by %llu\n", n); + } mutex_unlock(¬ifier_event->lock); } @@ -2073,7 +2079,7 @@ void hl_notifier_event_send_all(struct hl_device *hdev, u64 event_mask) mutex_lock(&hdev->fpriv_list_lock); list_for_each_entry(hpriv, &hdev->fpriv_list, dev_node) - hl_notifier_event_send(&hpriv->notifier_event, event_mask); + hl_notifier_event_send(hdev, &hpriv->notifier_event, event_mask); mutex_unlock(&hdev->fpriv_list_lock); } -- 2.34.1