Hi Andi,
On 12/28/23 08:40, Andi Shyti wrote:
> Hi Randy,
>
> [...]
>
>> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
>> @@ -105,61 +105,67 @@ struct intel_guc {
>> */
>
>
> struct { } interrupts is missing here.
>
>> struct {
>> /**
>> - * @lock: protects everything in submission_state,
>> - * ce->guc_id.id, and ce->guc_id.ref when transitioning in and
>
> [...]
>
>> + * we start bypassing the schedule disable delay
>> */
>> unsigned int sched_disable_gucid_threshold;
>> } submission_state;
>
> Here struct { } send_regs is missing
scripts/kernel-doc didn't report any problems with those, but it does
appear (to me) to be a kernel-doc bug. :(
Thanks.
> But as for this patch:
>
> Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>
>
> Thanks,
> Andi
>
>> struct {
>> /**
>> - * @lock: Lock protecting the below fields and the engine stats.
>> + * @timestamp.lock: Lock protecting the below fields and
>
> [...]
--
#Randy
