Hi Randy, ... > /** > * struct intel_gsc - graphics security controller > * > - * @gem_obj: scratch memory GSC operations > - * @intf : gsc interface > + * @intf : gsc interface > + * @intf.adev : MEI aux. device for this @intf > + * @intf.gem_obj : scratch memory GSC operations > + * @intf.irq : IRQ for this device (%-1 for no IRQ) > + * @intf.id : this interface's id number/index > */ I don't really like the tabs here and the space before the ':', which makes it a bit harder to read. Besides it doesn't look consistent with the rest of the documentation. Otherwise, looks good. Andi
