Re: [PATCH 1/3] drm/i915/gt: Support fixed CCS mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Joonas,

> > +       /*
> > +        * Track fixed mapping between CCS engines and compute slices.
> > +        *
> > +        * In order to w/a HW that has the inability to dynamically load
> > +        * balance between CCS engines and EU in the compute slices, we have to
> > +        * reconfigure a static mapping on the fly. We track the current CCS
> > +        * configuration (determined by inspection of the user's engine
> > +        * selection during execbuf) and compare it against the current
> > +        * CCS_MODE (which maps CCS engines to compute slices).  If there is
> > +        * only a single engine selected, we can map it to all available
> > +        * compute slices for maximal single task performance (fast/narrow). If
> > +        * there are more then one engine selected, we have to reduce the
> > +        * number of slices allocated to each engine (wide/slow), fairly
> > +        * distributing the EU between the equivalent engines.
> > +        */
> 
> This comment is outdated as we don't consider execbuf but the sysfs
> configuration.

yes, I removed some parts of the original comment already, but
yes, I agree it can be improved.

Thanks,
Andi



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux